Skip to content

Implement cross platform solution for deleting directory symlinks #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schmengler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement cross platform solution for deleting directory symlinks #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modman.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,8 +1171,9 @@ public function doRemoveResource($sElementPath){
if (is_link($sElementPath) OR $this->isFolderEmpty($sElementPath)){
// workaround for windows to delete read-only flag
// which prevents link from being deleted properly
chmod($sElementPath, 0777);
rmdir($sElementPath);
chmod($sElementPath, 0777);
// directory symlinks must be deleted with rmdir on windows
@unlink($sElementPath) or rmdir($sElementPath);
}
} elseif (is_file($sElementPath)){
// workaround for windows to delete read-only flag
Expand Down