Tests fail when no '.' in @INC ( Can't locate t/lib/db-common.pl in @INC )

[kentfredric]

When no '.' is in @inc on Perl 5.25.11 or newer ( the default when testing by hand, or when PERL_USE_UNSAFE_INC=0 is set in ENV )
Tests fail as follows:

t/00-compile.t ............. ok
t/02-basic.t ............... skipped: Tests require DBD::SQLite
t/03-primary-keys.t ........ skipped: Tests require DBD::SQLite
t/04-clone.t ............... skipped: Tests require DBD::SQLite
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/01-col-inheritance.t line 7.
t/01-col-inheritance.t ..... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/05-deflate.t ............. skipped: Tests require DBD::SQLite
t/06-errors.t .............. skipped: Tests require DBD::SQLite
t/07-has-a-cached.t ........ skipped: Tests require DBD::SQLite
t/07-has-a.t ............... skipped: Tests require DBD::SQLite
t/08-iterator.t ............ skipped: Tests require DBD::SQLite
t/12-windows.t ............. skipped: Tests require DBD::SQLite
t/11-sql.t ................. ok
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/09-resultset.t line 7.
t/09-resultset.t ........... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/31-cached.t .............. skipped: Tests require DBD::SQLite
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/10-resultset-peek.t line 10.
t/10-resultset-peek.t ...... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/33-views.t ............... skipped: Tests require DBD::SQLite
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/20-driver-sqlite.t line 7.
t/20-driver-sqlite.t ....... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/34-both.t ................ skipped: Tests require DBD::SQLite
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib/partitioned /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/32-partitioned.t line 7.
t/32-partitioned.t ......... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib/multiplexed /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/35-multiplexed.t line 7.
t/35-multiplexed.t ......... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/50-profiling.t ........... skipped: Tests require DBD::SQLite
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib/partitioned /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/42-callbacks-multi-pk.t line 7.
t/42-callbacks-multi-pk.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
Can't locate t/lib/db-common.pl in @INC (@INC contains: t/lib /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/arch /home/kent/.cpanm/work/1492242506.23302/Data-ObjectDriver-0.14/blib/lib /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/41-callbacks.t line 7.
t/41-callbacks.t ........... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 

[kentfredric]

See also: http://cpan.simcop2387.info/logs/Data::ObjectDriver_incfailure.log

Thank you for your information. We will fix it.

App::cpanminus@1.7043 has fixed this problem already.
miyagawa/cpanminus#521

[kentfredric]

That's not a fix. That's a temporary workaround.

[kentfredric]

Importantly: This means people who aren't using CPAN.pm/cpanm will also experience this problem in the short term.

Examples:

1. People running tests by hand

Also, the approach used by cpanm makes tests pass, at the expense of suppressing potential runtime bugs.

( That is, code in lib/ having implicit dependency on '.' )

I don't think your code falls into the latter case, but there's no way to know if you don't test for it. And that approach simply means you're not testing it.

I'm sorry. I will fix this.

I wrote that comment as a memo. I was able to reproduce failed test at first, but I was not able to reproduce it on other environment. I kept investigating the cause.

[kentfredric]

The easy way to make sure your tests fail when broken is to set PERL_USE_UNSAFE_INC=0

This is because both cpanm and TAP::Harness use the logic:

$ENV{PERL_USE_UNSAFE_INC} = 1 unless exists $ENV{PERL_USE_UNSAFE_INC}

Hence, setting an explicit assignment to =0 prevents the other layers flipping that bit again.

Thank you very much!

[comewalk]

@kentfredric @miniuchi
Uploaded new version. http://search.cpan.org/~sixapart/Data-ObjectDriver-0.15/
Thanks!