Skip to content

Avoid SQL syntax error: column IN ()#26

Merged
comewalk merged 10 commits intosixapart:masterfrom
charsbar:fix/avoid_column_in_empty_list
Mar 7, 2019
Merged

Avoid SQL syntax error: column IN ()#26
comewalk merged 10 commits intosixapart:masterfrom
charsbar:fix/avoid_column_in_empty_list

Conversation

@charsbar
Copy link
Contributor

@charsbar charsbar commented Feb 7, 2019

@coveralls
Copy link

coveralls commented Feb 7, 2019

Coverage Status

Coverage decreased (-0.3%) to 83.547% when pulling e7871f4 on charsbar:fix/avoid_column_in_empty_list into eaa8c4c on sixapart:master.

@coveralls
Copy link

coveralls commented Feb 7, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 83.708% when pulling 8c3e027 on charsbar:fix/avoid_column_in_empty_list into eaa8c4c on sixapart:master.

@ghost ghost self-requested a review February 12, 2019 07:27
usualoma
usualoma reviewed Mar 7, 2019
View reviewed changes
lib/Data/ObjectDriver/SQL.pm
} elsif (ref($val) eq 'SCALAR') {
$col = $m->($col) if $m = $stmt->column_mutator;
$term = "$col $$val";
} elsif (ref($val) eq 'REF') {
Copy link
Member

@usualoma usualoma Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charsbar
I think we should also apply column_mutator at this block.

        $col = $m->($col) if $m = $stmt->column_mutator;

Copy link
Contributor Author

@charsbar charsbar Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

usualoma
usualoma approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@usualoma usualoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very nice PR!

@comewalk comewalk merged commit 6b19220 into sixapart:master Mar 7, 2019
comewalk added a commit that referenced this pull request Mar 7, 2019
@comewalk
Checking in changes prior to tagging of version 0.16.
9b63a6d 
Changelog diff is:

diff --git a/Changes b/Changes
index ed959bd..2784461 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,12 @@
 {{$NEXT}}

+0.16 2019-03-07T07:07:14Z
+
+    - Avoid SQL syntax error: column IN () (charsbar) #26
+    - Add disconnect method explicitly to pass tests for windows (twata1) #25
+
+0.15 2017-04-19T01:41:02Z
+
     - Fix failed tests with Perl 5.25.11 (miniuchi) #24

 0.14 2016-01-14T03:03:02Z
comewalk added a commit that referenced this pull request Mar 12, 2019
@comewalk
Checking in changes prior to tagging of version 0.17.
42d1546 
Changelog diff is:

diff --git a/Changes b/Changes
index 2784461..bbda592 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 {{$NEXT}}

+0.17 2019-03-12T04:24:20Z
+
+    - Bump version
+
 0.16 2019-03-07T07:07:14Z

     - Avoid SQL syntax error: column IN () (charsbar) #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usualoma usualoma usualoma approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charsbar @coveralls @usualoma @comewalk