Merged
Conversation
comewalk
approved these changes
Oct 29, 2020
Member
comewalk
left a comment
comewalk
left a comment
There was a problem hiding this comment.
Good job 👍
I ran prove -lv t/60-fork.t with both DOD_FORK_SAFE=1 and DOD_FORK_SAFE=0. These results were as I expected 😃
comewalk
added a commit
that referenced
this pull request
Oct 29, 2020
Changelog diff is: diff --git a/Changes b/Changes index 86eb37e..c55ccb1 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,10 @@ {{$NEXT}} +0.21 2020-10-29T05:54:05Z + - Add GitHub Actions #38 + - Support DBD::MariaDB #39 + - Fork safety #40 + 0.20 2020-09-14T12:15:54Z - Fix tests (Thanks to eseyman) #36 - Change license (Thanks to kentfredric) #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is reimplementation of #27. This PR does not tweak the transaction level of DOD because forking in a transaction is a bad idea by itself. This PR also uses AutoInactiveDestroy, instead of InactiveDestroy for simplicity.