Support other data types for simdd file #158
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These updates the SimDD.schema to support more types, especially int types. Note that DevInt is no longer a supported type. The rest of the changes are to test that we are able to generate a device and read the int type attributes. I have also updated the tango_sim_generator module to ensure that the attribute write type defaults to READ if it is not specified in the config file. Resolves: #156 Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Resolves: #156 Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Resolves: #156 Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes extend the features of provided by the SimDD file. This is to allow the users to be able to specify attributes of integer type, that is:
ShortUShortLongULongLong64ULong64I have also added simple tests to validate that the generated device will expose the attributes and that they are readable.
Screenshots or code snippets (if appropriate):
N/A
Definition of Done Checklist
SKA-JIRA: 442