Skip to content

Deduplication#6

Merged
picolino merged 4 commits intomasterfrom
issue-2-deduplication
Mar 7, 2023
Merged

Deduplication#6
picolino merged 4 commits intomasterfrom
issue-2-deduplication

Conversation

@picolino
Copy link
Copy Markdown
Contributor

@picolino picolino commented Mar 7, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

⤵️ What is the current behavior?

  1. When you start application instance no matter if this app instance bounded to tcp listener or not - current app instance connects to remote known peers and all local peers
  2. If three app instances knows about each other and sending messages to each other - then messages duplication appears.

🆕 What is the new behavior (if this is a feature change)?

  1. Application connects to known peers only if it bounded to tcp listener.
  2. Deduplication applying when receiving message duplicate

💥 Does this PR introduce a breaking change?

Yes, because network topology was changed.

@picolino picolino self-assigned this Mar 7, 2023
@picolino picolino merged commit a3d91df into master Mar 7, 2023
@picolino picolino deleted the issue-2-deduplication branch March 7, 2023 09:02
@picolino picolino linked an issue Mar 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Three-body connections produces messages duplication

1 participant