fix: gracefully handle missing SQLite FTS5 on Windows#65
Merged
Conversation
Probes FTS5 availability with an in-memory test table before attempting index operations. When FTS5 is missing (common on Windows Node.js binaries), throws SearchDepsUnavailableError so existing handlers skip indexing gracefully instead of crashing. Closes #64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #64
❓ Type of change
📚 Description
Node.js's built-in SQLite on Windows doesn't include the FTS5 module, causing
skilld addto crash with "no such module: fts5" during search indexing. This adds an in-memory FTS5 probe ingetDb()that runs once and caches the result. When FTS5 is unavailable, it throwsSearchDepsUnavailableErrorso existing handlers skip indexing gracefully with a helpful message instead of crashing.