Skip to content

BUG: After setting model_diagram=False on instantiated model card, the diagram is still shown #292

@BenjaminBossan

Description

@BenjaminBossan

It would be nice to be able to disable the model diagram after the model card has been instantiated by setting the attribute to False. However, this does not happen:

from sklearn.dummy import DummyClassifier
from skops import card

clf = DummyClassifier()
c = card.Card(clf)
print(c.model_diagram)  # True

c.model_diagram = False
c.render()  # still contains the model diagram

It is not difficult to work around this, as a user I can simply do:

c.delete("Model description/Training Procedure/Model Plot")

but it's inconvenient.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions