MNT Add matplotlib and pandas as test dependencies#151
Merged
adrinjalali merged 1 commit intoskops-dev:mainfrom Sep 26, 2022
Merged
MNT Add matplotlib and pandas as test dependencies#151adrinjalali merged 1 commit intoskops-dev:mainfrom
adrinjalali merged 1 commit intoskops-dev:mainfrom
Conversation
Fixes skops-dev#148 matplotlib and pandas are currently not test dependencies (only docs) but actually, tests cannot run without them. Not it should be possible to successfully run: pip install skops[tests] pytest skops (I tested locally with pip install -e .[tests]) Implementation There was already the possibility to declare the same dependency for multiple "extras" by using ", " as separator. Personally, I would have preferred a tuple like so: dependent_packages = { ..., ("pandas": ("1", ("docs", "tests"), None)), } but I guess the code is like this because sklearn does it the same.
Collaborator
Author
|
Forgot to ping: Ready for review @skops-dev/maintainers |
adrinjalali
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Description
matplotlib and pandas are currently not test dependencies (only docs) but actually, tests cannot run without them.
Now it should be possible to successfully run:
(I successfully tested locally with
pip install -e .[tests])Implementation
There was already the possibility to declare the same dependency for multiple
extrasby using", "as separator. Personally, I would have preferred a tuple like so:but I guess the code is like this because sklearn does it the same.
Other
If merged, allows to simplify install in #147