MNT Model card refactor to move plotting & table#163
Merged
adrinjalali merged 5 commits intoskops-dev:mainfrom Oct 5, 2022
Merged
MNT Model card refactor to move plotting & table#163adrinjalali merged 5 commits intoskops-dev:mainfrom
adrinjalali merged 5 commits intoskops-dev:mainfrom
Conversation
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
I have a comment that might simplify the code a bit, otherwise LGTM.
Regarding the testing, we could test exactly the case where card.model is reassigned, but I don't think it's strictly necessary.
BenjaminBossan
approved these changes
Sep 30, 2022
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
adrinjalali
approved these changes
Oct 5, 2022
adrinjalali
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #157.
I moved plot & hyperparameter table to
_generate_card()to keepsave()atomic, given it's already called duringsave(). Does it sound good?