-
Notifications
You must be signed in to change notification settings - Fork 61
Alternative Card implementation #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
E-Aho
merged 31 commits into
skops-dev:main
from
BenjaminBossan:alternative-model-card-implementation
Dec 16, 2022
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
faf9e37
[skip ci] [WIP] Alternative Card implementation
BenjaminBossan cc229a2
[WIP] Further align new model card design
BenjaminBossan 166e33d
Make tests pass
BenjaminBossan a90e3a5
Add tests for new functionalities and docstrings
BenjaminBossan fcbd0df
Adjust tests to work with older sklearn versions
BenjaminBossan 4f10f80
Adjust examples to new card, more docs
BenjaminBossan 0f5df2e
Continue fixing tests
BenjaminBossan 6212d67
Try fixing Windows error by specifying encoding
BenjaminBossan 80d218d
Adjust doctest: confusion matrix not stored in cwd
BenjaminBossan c6c8042
Increase test coverage
BenjaminBossan e7a2ae3
Try fixing test failure on Windows
BenjaminBossan 2a6aab0
Replace old by new Card implementation
BenjaminBossan ce16019
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan 00b7665
Address reviewer comments
BenjaminBossan 8558f26
Add TODO notes for when Python 3.7 is dropped
BenjaminBossan fdb7674
Add Hub model card template, add template arg
BenjaminBossan 772a659
Make _add_single return the Section
BenjaminBossan 7cfddf9
Allow tables without rows to be added
BenjaminBossan 26892d6
Error when calling add_metric w/ invalid template
BenjaminBossan f0c496d
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan b4d821b
Some amendments required after merging
BenjaminBossan 0b66e14
A couple more changes:
BenjaminBossan d859c00
Add entry to changes.rst
BenjaminBossan 4af4b12
Fix small bug in generated code for loading
BenjaminBossan c5c21e6
Address reviewer comments
BenjaminBossan 00ec8a2
Adjust getting started code in model card
BenjaminBossan 9ee11fe
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan 91a5b7a
Adjust docstrings
BenjaminBossan 4564dc3
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan fa00e03
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan 68e4748
Allow adding default sections with custom template
BenjaminBossan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.