MNT Fixes for hf_hub v0.11.0#213
Merged
adrinjalali merged 10 commits intoskops-dev:mainfrom Nov 17, 2022
Merged
Conversation
adrinjalali
reviewed
Nov 14, 2022
adrinjalali
reviewed
Nov 14, 2022
- Use ModelCardData instead of CardData - Use token instead of use_auth_token - If model_file is not found, default to joblib load instruction
Collaborator
Author
|
@skops-dev/maintainers I tried with the new `huggingface_hub==0.11.0rc1" and CI passed so this should be good to go. |
Member
|
Does this also pass with our minimum dependency of |
Collaborator
Author
Yes, that's 0.10.1, so the most up-to-date before the 0.11 release. I tested it and it works. |
adrinjalali
approved these changes
Nov 17, 2022
adrinjalali
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@skops-dev/maintainers This PR started out as a test if upgrading to hf_hub 0.11 would work. Since it caused some mypy errors, I updated the code to fix it, so it should now be compatible once 0.11 is released. Please review.