MNT add helper functions to convert types to strings in .audit#215
Conversation
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Pretty good overall, thanks. I only have minor comments, please take a look.
PS: I didn't see Adrin's review when I wrote this one.
…f github.com:E-Aho/skops into ENH-Add-helper-functions-to-convert-types-to-strings
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
We can have a separate PR to work on the public API allowing users to pass types.
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Looks, great, this PR can be merged, there are just two minor improvements for docstrings that I would suggest.
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
|
you might want to enable pre-commit hooks, which include |
|
I've got that all set up on my personal computer, trying to wrestle through it on my work laptop atm to get this merged lol |
|
This is a good reminder to me how nice it is to have pre-commit hooks 🙃 Should be good to go now |
adrinjalali
changed the title
|
Note: I change the commit title to MNT since this doesn't expose any changes to the user. I feel like ENH has user-facing implications. |
E-Aho
deleted the
ENH-Add-helper-functions-to-convert-types-to-strings
branch
3 participants
A few minor changes to the new audit functionality that allows us to pass in types as well as strings as defaults.
This PR adds in a few helper functions to convert from types to their namespace strings, and a helper function that can convert any non-string
defaultsin a passed in list to their namespace.Also includes new tests that cover this added functionality