Skip to content

CI fix clean_skops.py#235

Merged
BenjaminBossan merged 1 commit intoskops-dev:mainfrom
adrinjalali:clean-ci
Dec 2, 2022
Merged

CI fix clean_skops.py#235
BenjaminBossan merged 1 commit intoskops-dev:mainfrom
adrinjalali:clean-ci

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali commented Dec 2, 2022

Fixes #231

This fixes the broken clean_skops.py.

  • We can now pass the token to the client instance
  • The output of list_models is a generator now
  • Most models are private, so the token was required to list them, which were previously ignored

cc @skops-dev/maintainers

The script works locally now.

Copy link
Copy Markdown
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@BenjaminBossan BenjaminBossan merged commit 53119d7 into skops-dev:main Dec 2, 2022
@adrinjalali adrinjalali deleted the clean-ci branch December 2, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clean_skops.py job broken

2 participants