ENH All sklearn estimators in trusted list

[EdAbati]

Fixes #223

Hi all, I have added all sklearn estimators to the trusted list of ObjectNode and added test for it.

A couple of things that I am not 100% sure about:

• the issue mentioned to add some 'sanity checks' when getting the list of estimators. For now I am checking that the module name starts with 'sklearn.', should I add any extra ones?
• is ObjectNode the only place where we should add the sklearn estimators in the trusted list? What about TypeNode?
• I have extracted get_tested_estimators in a common place (testing_utils.py) so I could reuse it. I could not use the name common.py because there is already a common.py in hub_utils and pytest complained. Should we maybe have a common utils file for all the tests?

[adrinjalali]

Thanks for the PR @EdAbati , this looks great.

[BenjaminBossan]

@adrinjalali You are most qualified to review this, would you take it?

• I have extracted get_tested_estimators in a common place (testing_utils.py) so I could reuse it. I could not use the name common.py because there is already a common.py in hub_utils and pytest complained. Should we maybe have a common utils file for all the tests?

I don't think we need a "common" common.py, since the different sub-modules deal with quite different objectives. Regarding the name, I feel like testing_ is a bit redundant, since we're already in the tests directory, so how about just _utils.py?

EDIT: Wrote this before seeing Adrin's reply.

[adrinjalali]

It's definitely worth having a way to get other types which are not trusted by this PR, but I don't think we should have that list in the codebase.

[EdAbati]

Hi @adrinjalali , I tweaked the unittest it looks nicer now, thanks :)

Regarding instead:

It's definitely worth having a way to get other types which are not trusted

do you have anything in mind?

[adrinjalali]

This LGTM. Thanks @EdAbati . Could you please also add an entry in our changelog?

[EdAbati]

Thank you @adrinjalali for the help! :)
I have updated the changelog.