DOC make the persistence warning the same as the user guide#259
Merged
BenjaminBossan merged 1 commit intoskops-dev:mainfrom Dec 19, 2022
Merged
DOC make the persistence warning the same as the user guide#259BenjaminBossan merged 1 commit intoskops-dev:mainfrom
BenjaminBossan merged 1 commit intoskops-dev:mainfrom
Conversation
BenjaminBossan
approved these changes
Dec 19, 2022
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
I'm fine with the change in wording.
Before merging, for my understanding, you mean this needs to be updated quick because sklearn will soon link to skops? Or how is it related?
Member
Author
|
Yes, the link to skops is already live on sklearn's dev branch, but will go live on the stable branch soon too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hotfix to make the warning in the API docs the same as the user guide.
Since scikit-learn/scikit-learn#25197 this merged and might be backported to the stable release soon, we should fix this warning, and backport it to the 0.4.X branch. It won't require a new release since it's only a documentation change.
I'll merge tomorrow if nobody else does. I don't like urgent things, but this might hurt us if we don't fix it soon.
cc @skops-dev/maintainers