Skip to content

FIX: Persistence tests failing when using sklearn nightly #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrinjalali merged 1 commit into from
Jan 2, 2023
Merged

FIX: Persistence tests failing when using sklearn nightly #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions skops/io/tests/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,13 @@ def _assert_vals_equal(val1, val2):


def assert_params_equal(params1, params2):
# due to https://github.com/scikit-learn/scikit-learn/pull/22094, after
# loading an sklearn estimator, there might be an entry called
# "__sklearn_pickle_version__" in the __dict__ that wasn't there before. We
# just ignore it.
params1.pop("__sklearn_pickle_version__", None)
params2.pop("__sklearn_pickle_version__", None)

# helper function to compare estimator dictionaries of parameters
assert len(params1) == len(params2)
assert set(params1.keys()) == set(params2.keys())
Expand Down