MNT Turn off CatBoost verbosity in tests#262
Merged
adrinjalali merged 1 commit intoskops-dev:mainfrom Jan 5, 2023
Merged
Conversation
By default, catboost prints a giant output to stdout when fitting. This is annoying when running the tests, which include fitting catboost. Normally, this does not matter, as pytest captures stdout, but when running pytest with -s (e.g. for debugging purposes or in CI), the output is flooded. This PR adds verbose=False when initializing the catboost estimators, which prevents any output from being shown.
E-Aho
approved these changes
Jan 5, 2023
Collaborator
E-Aho
left a comment
E-Aho
left a comment
There was a problem hiding this comment.
LGTM, can merge this in once the tests are done
adrinjalali
approved these changes
Jan 5, 2023
adrinjalali
changed the title
Collaborator
Author
|
Lightning fast reviews :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, catboost prints a giant output to stdout when fitting. This is annoying when running the tests, which include fitting catboost. Normally, this does not matter, as pytest captures stdout, but when running pytest with
-s(e.g. for debugging purposes or in CI), the output is flooded.This PR adds
verbose=Falsewhen initializing the catboost estimators, which prevents any output from being shown.