Skip to content

Fix for metadata having model format #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminBossan merged 3 commits into from
Jan 20, 2023
+15 −2
Merged

Fix for metadata having model format #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc82124
fix for metadata
merveenoyan Jan 19, 2023
18b6a58
initialize modelcarddata with model_format
merveenoyan Jan 19, 2023
08cbffd
added test for skops
merveenoyan Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions skops/card/_model_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ def metadata_from_config(config_path: Union[str, Path]) -> ModelCardData:

with open(config_path) as f:
config = json.load(f)

card_data = ModelCardData()
card_data = ModelCardData(
model_format=config.get("sklearn", {}).get("model_format", {})
)
card_data.library_name = "sklearn"
card_data.tags = ["sklearn", "skops"]
task = config.get("sklearn", {}).get("task", None)
Expand Down
12 changes: 12 additions & 0 deletions skops/card/tests/test_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,18 @@ def test_metadata_from_config_tabular_data(
for tag in ["sklearn", "skops", "tabular-classification"]:
assert tag in metadata["tags"]

def test_metadata_model_format_pkl(
self, pkl_model_card_metadata_from_config, destination_path
):
metadata = metadata_load(local_path=Path(destination_path) / "README.md")
assert metadata["model_format"] == "pickle"

def test_metadata_model_format_skops(
self, skops_model_card_metadata_from_config, destination_path
):
metadata = metadata_load(local_path=Path(destination_path) / "README.md")
assert metadata["model_format"] == "skops"


@pytest.mark.xfail(reason="dynamic adjustment when model changes not implemented yet")
class TestModelDynamicUpdate:
Expand Down