Skip to content

MNT Fixes for huggingface_hub 0.12 compatibility#274

Merged
adrinjalali merged 1 commit intoskops-dev:mainfrom
BenjaminBossan:maint-hf_hub-0.12-compatibility
Jan 20, 2023
Merged

MNT Fixes for huggingface_hub 0.12 compatibility#274
adrinjalali merged 1 commit intoskops-dev:mainfrom
BenjaminBossan:maint-hf_hub-0.12-compatibility

Conversation

@BenjaminBossan
Copy link
Copy Markdown
Collaborator

Following up the discussion in #273

  • ignore mypy error in snapshot_download
  • account for changed error message

- ignore mypy error in snapshot_download
- account for changed error message
@BenjaminBossan
Copy link
Copy Markdown
Collaborator Author

I tested locally with huggingface_hub==0.12.0.rc0 and it worked.

Ready for review @skops-dev/maintainers

@adrinjalali adrinjalali changed the title Fixes for huggingface_hub 0.12 compatibility MNT Fixes for huggingface_hub 0.12 compatibility Jan 20, 2023
@adrinjalali adrinjalali merged commit 1fd7982 into skops-dev:main Jan 20, 2023
@BenjaminBossan BenjaminBossan deleted the maint-hf_hub-0.12-compatibility branch January 20, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants