Skip to content

DOC add PR prefixes to maintainer docs#282

Merged
BenjaminBossan merged 1 commit intoskops-dev:mainfrom
adrinjalali:git-msg
Jan 24, 2023
Merged

DOC add PR prefixes to maintainer docs#282
BenjaminBossan merged 1 commit intoskops-dev:mainfrom
adrinjalali:git-msg

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

Fixes #217

cc @skops-dev/maintainers

Copy link
Copy Markdown
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, LGTM.

I don't think the final commit message necessarily has to be short, but that's a nit.

@BenjaminBossan BenjaminBossan merged commit 9bf557e into skops-dev:main Jan 24, 2023
@adrinjalali adrinjalali deleted the git-msg branch January 24, 2023 16:52
@adrinjalali
Copy link
Copy Markdown
Member Author

I agree, I don't mind longer messages you write, they're nice.

@BenjaminBossan BenjaminBossan changed the title DOC add PR preffixes to maintainer docs DOC add PR prefixes to maintainer docs Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add maintainers guide

2 participants