MNT/MAINT upgrading isort to 5.12.0

[omar-araboghli]

Closes #293

[BenjaminBossan]

Thanks for providing a fix so quickly.

Before going ahead, could you please describe how I could replicate the initial problem? I tried creating a fresh environment as described in CONTRIBUTING.rst (except I used conda instead of mamba) and it worked without your fix (incl. running pre-commit run). Is it something that only surfaces when using poetry? From the commit you linked, it's not clear to me why that would break pre-commit.

Independent of that, I think we can still merge it, I just want to better understand the issue.

[omar-araboghli]

@BenjaminBossan Thanks for your feedback! Interesting... These are the reproduction steps:

• Create a conda environment via PyCharm with python 3.10
• python -m pip install -e ".[tests,docs]"
• conda install pre-commit
• pre-commit install

Maybe I should have followed CONTRIBUTING.rst more strictly, but as you already said. It's safer to merge and make skops up-to-date with its dependencies.

[BenjaminBossan]

• Create a conda environment via PyCharm with python 3.10

Interesting, this seems to be the only step that differs. Do you have an idea what PyCharm could be doing differently here that would cause the issue? I have conda 23.1.0 but I don't think the conda version should be the cause. And somehow, in the error log you pasted, poetry seems to be involved. Does PyCharm use that under the hood?

[omar-araboghli]

From the error log I understood that an older version of isort is being installed based on isort's recent pyproject.yaml. I also couldn't find any different behavior while creating a conda environment by PyCharm so far. So I freshly cloned the repo and exactly followed the contributing guidelines this time and still getting the same error 😮.

[BenjaminBossan]

Heh, strange. Still, I merged since it shouldn't hurt and there may be other PyCharm users out there who run into the same issue (note that it seems like they backported the fix to 5.11 too: https://github.com/PyCQA/isort/releases/tag/5.11.5).

For the @skops-dev/maintainers and others who work on the repo, please make sure to update pre-commit, not sure if it does so automatically.