Skip to content

MNT: refactor model card to render sections lazily #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrinjalali merged 7 commits into from
Mar 7, 2023
Merged

MNT: refactor model card to render sections lazily #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85503ed
[WIP] Refactor Card to lazily format sections
BenjaminBossan Mar 2, 2023
d2585a0
Add missing tests and docstrings
BenjaminBossan Mar 2, 2023
0669b28
Fix repr, Windows does not use /
BenjaminBossan Mar 2, 2023
833aced
Add description param to permutation importances
BenjaminBossan Mar 3, 2023
87547df
Remove Section abstract class
BenjaminBossan Mar 3, 2023
18c0855
Address reviewer comments
BenjaminBossan Mar 3, 2023
b66db87
Reviewer comment: how to init class
BenjaminBossan Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skops/card/_markup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def _table(self, item) -> str:
data_transposed = zip(*body)
table = {key: val for key, val in zip(columns, data_transposed)}

res = TableSection(table).format()
res = TableSection(title="", content="", table=table).format()
return res

def _parse_div(self, item) -> str:
Expand Down
Loading