CI add codecov token to the config#312
Merged
BenjaminBossan merged 2 commits intoskops-dev:mainfrom Mar 7, 2023
Merged
Conversation
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Ah I see, it's the same issue again about exposing secrets to forks. I wonder if GH could fix that without leaking the secret, but even if possible, we can't wait for it.
| notify: | ||
| after_n_builds: 12 | ||
| wait_for_ci: true | ||
| token: 2b8d4d69-6de6-4e1d-840a-5ccf9d849565 |
Collaborator
There was a problem hiding this comment.
How about a comment about why it's okay to include the token here?
Member
Author
I don't think it's something GH wants to "fix". |
BenjaminBossan
approved these changes
Mar 7, 2023
Collaborator
Yeah, at this point probably not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codecov token we have is not actually used in PRs since it's a token on GH, and they're not exposed to
pull_requesttriggered actions.The recommended action seems to be adding it hard coded, which doesn't really pose any security risks: codecov/feedback#126