DOC make sklearn's estimator run in parallel in the intelex example#316
Merged
BenjaminBossan merged 7 commits intoskops-dev:mainfrom Mar 13, 2023
Merged
DOC make sklearn's estimator run in parallel in the intelex example#316BenjaminBossan merged 7 commits intoskops-dev:mainfrom
BenjaminBossan merged 7 commits intoskops-dev:mainfrom
Conversation
Collaborator
|
Does intelex also use all cores? Otherwise, it's not an apples to apples comparison. Moreover, I see now that we initially missed incorrect reporting of log loss:
doesn't make sense, the f-string should not use |
BenjaminBossan
requested changes
Mar 13, 2023
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Looks good, just some minor formatting thing. There is one more :.1% at the bottom of the doc.
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
BenjaminBossan
approved these changes
Mar 13, 2023
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Looks good, thx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my local machine, this changes the speedup from 15 to 3. sklearn is not that slow.