Skip to content

FIX: Workflow file for persistence performance#326

Merged
adrinjalali merged 19 commits intoskops-dev:mainfrom
BenjaminBossan:fix-persistence-performance-GH-workflow
Mar 27, 2023
Merged

FIX: Workflow file for persistence performance#326
adrinjalali merged 19 commits intoskops-dev:mainfrom
BenjaminBossan:fix-persistence-performance-GH-workflow

Conversation

@BenjaminBossan
Copy link
Copy Markdown
Collaborator

  • wrong name
  • trying to fix install

- wrong name
- trying to fix install
@BenjaminBossan
Copy link
Copy Markdown
Collaborator Author

@skops-dev/maintainers ready for review

@adrinjalali
Copy link
Copy Markdown
Member

Could you please set this to trigger on PR so that we can test it here and see if the install actually fixes the issue?

@BenjaminBossan
Copy link
Copy Markdown
Collaborator Author

(don't merge yet)

@adrinjalali While the fundamental issue still exists, I found a "solution" by copying the script to the project root inside the GH action. WDYT?

@adrinjalali
Copy link
Copy Markdown
Member

Since this is to "fix" import issues, would it work if we do an os.chdir or something inside the script instead, to run it from the root, before running the import statements? I'm not sure which one's better.

But I'm happy to merge and revert once actions/setup-python#634 is resolved maybe?

@BenjaminBossan
Copy link
Copy Markdown
Collaborator Author

I don't see any advantage either way, so I just left it as is but added a comment to revert the change once the issue is solved. Also removed the PR hook, so this should be ready to be merged.

- name: Run persistence performance checks
run: python scripts/check_persistence_performance.py
run: |
python3.11 scripts/check_persistence_performance.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably can be python3 or even python, right? You can probably revert these two lines to what it was before actually.

All columns together exceed GH column width.
...in an attempt to get the column width down
@BenjaminBossan
Copy link
Copy Markdown
Collaborator Author

@adrinjalali This works now, here is an output: https://github.com/skops-dev/skops/actions/runs/4531268169/jobs/7981214101?pr=326

I have removed the PR hook again, so we'll be 100% certain in 1 week :)

@adrinjalali adrinjalali merged commit ee7009d into skops-dev:main Mar 27, 2023
@BenjaminBossan BenjaminBossan deleted the fix-persistence-performance-GH-workflow branch March 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants