FIX: Bug in random generator persistence#331
Merged
adrinjalali merged 3 commits intoskops-dev:mainfrom Mar 28, 2023
Merged
Conversation
One of its children was not persisted correctly (pure dict instead of DictNode), which made it impossible to check the untrusted types on it. This fix correctly stores the state as a node. Tests were extended to uncover this bug. The old persistence scheme was preserved for protocol vesion 0 -- even though it is buggy, it can work under some circumstances.
Collaborator
Author
|
@skops-dev/maintainers ready for review |
adrinjalali
reviewed
Mar 28, 2023
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
This needs a changelog, otherwise LGTM.
adrinjalali
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
One of its children was not persisted correctly (pure dict instead of
DictNode), which made it impossible to check the untrusted types on it. This fix correctly stores the state as a node.Note that the old implementation does correctly load the
Generatorinstance, but it doesn't work with anything buttrusted=True.Tests were extended to uncover this bug.
The old persistence scheme was preserved for protocol vesion 0 -- even though it is buggy, it can work under some circumstances.