ENH expose compression and compression level to the user API#345
Merged
BenjaminBossan merged 3 commits intoskops-dev:mainfrom Apr 21, 2023
Merged
ENH expose compression and compression level to the user API#345BenjaminBossan merged 3 commits intoskops-dev:mainfrom
BenjaminBossan merged 3 commits intoskops-dev:mainfrom
Conversation
|
Sweet! Let me know when this change is live. It feels like it's a change that I'd like to put in the calmcode video. |
BenjaminBossan
approved these changes
Apr 20, 2023
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
LGTM, thx. I made some suggestions but none are must haves for me. Feel free to merge if you don't like them :)
|
|
||
| compresslevel: int, default=None | ||
| The compression level to use. See :class:`zipfile.ZipFile` for more | ||
| information. |
Collaborator
There was a problem hiding this comment.
Do we want to make a recommendation (here or in the docs) about what settings to use? E.g. "if file size is no issue, use the defaults, as they are the fastest. Otherwise, use ".
Member
Author
There was a problem hiding this comment.
added something in the docs.
Member
Author
|
@koaning this is now released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
This exposes the
compressionandcompresslevelfromZipFileto the user.cc @koaning @skops-dev/maintainers