FIX attempt at fixing broken GH workflow#353
Merged
adrinjalali merged 2 commits intoskops-dev:mainfrom May 4, 2023
Merged
Conversation
The GitHub action for testing the performance of persistence is broken since the last two weeks. The error is: > ModuleNotFoundError: No module named 'skops.io' This seems to be the same issue we already had previously with broken installs. Nothing relevant has been changed on the workflow yaml, so there is really no reason why it should suddenly break. This PR attempts to fix the issue by making the following changes: - Use Python 3.10 insteaad of 3.11 - Use pip install with -e flag - Explicitly call python3.10 instead of just python A PR hook was added to trigger this workflow, it should be removed before merging.
It was just there for testing.
Collaborator
Author
|
@skops-dev/maintainers Ready for review. The changes seem to fix the issue. The failing CI job is unrelated. |
adrinjalali
approved these changes
May 4, 2023
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
It's so silly that we're having this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub action for testing the performance of persistence is broken since the last two weeks. The error is:
This seems to be the same issue we already had previously with broken installs. Nothing relevant has been changed on the workflow yaml, so there is really no reason why it should suddenly break.
This PR attempts to fix the issue by making the following changes:
-eflagpython3.10instead of justpythonA PR hook was added to trigger this workflow, it should be removed before merging.