ENH Set folded on model card add#361
Merged
adrinjalali merged 6 commits intoskops-dev:mainfrom Jun 12, 2023
Merged
Conversation
`model_card.add()`
lazarust
force-pushed
the
ENH-set-folded-on-model-card-add
branch
from
c82f4d6 to
cef3bd4
Compare
Contributor
Author
|
@adrinjalali Sorry this took me a while, I've addressed your comment! |
adrinjalali
approved these changes
Jun 12, 2023
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
Thanks, other than the changelog LGTM.
Comment on lines
+28
to
+29
| - Adds the abillity to set the :attr:`.Section.folded` property when using :meth:`.Card.add`. | ||
| :pr:`361` by :user:`Thomas Lazarus <lazarust>`. |
Member
There was a problem hiding this comment.
please move to the 0.8 section, we just released 0.7.
Contributor
Author
|
@adrinjalali Sorry about that should be in the right spot now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #360
What does this implement/fix? Explain your changes.
Adds the ability to set the
foldedproperty of a section when usingmodel_card.add()Any other comments?
This needs to wait until #341 is merged since it uses the
foldedproperty onSection.