MNT support array functions in numpy>=1.25#373
Conversation
|
cc @skops-dev/maintainers |
lazarust
left a comment
There was a problem hiding this comment.
I can't merge PRs but this looks good to me!
BenjaminBossan
left a comment
There was a problem hiding this comment.
Ugh, this is unfortunate.
It could very well happen sooner or later that we cannot rely on singledispatch anymore because of stuff like this. Hopefully I'm wrong but I wouldn't like to write a custom dispatcher (again).
|
The real dispatch here would be |
I would suggest that as long as it only affects this one function, we can live with the workaround; if there are more of exceptions needed in the future, we might have to roll our own dispatcher that can optionally use |
Persistence is broken since from
numpy=1.25.0np.meanis now dispatched via_ArrayFunctionDispatcher.This fixes the issue.
Also opened an issue here: numpy/numpy#24019
We should do a quick minor release for this probably.