Skip to content

MNT Bump actions/setup-python from 4 to 5 and fix tests#405

Merged
BenjaminBossan merged 10 commits intoskops-dev:mainfrom
adrinjalali:dependabot/github_actions/actions/setup-python-5
Dec 13, 2023
Merged

MNT Bump actions/setup-python from 4 to 5 and fix tests#405
BenjaminBossan merged 10 commits intoskops-dev:mainfrom
adrinjalali:dependabot/github_actions/actions/setup-python-5

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

Fixing the Card test errors while updating setup-python. Supersedes #404

dependabot Bot and others added 3 commits December 11, 2023 00:14
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@adrinjalali
Copy link
Copy Markdown
Member Author

Hmm, I can't reproduce the error locally.

Any ideas @BenjaminBossan ?

@adrinjalali
Copy link
Copy Markdown
Member Author

The issue was that I wasn't using the nightly build of scikit-learn

@adrinjalali adrinjalali changed the title Bump actions/setup-python from 4 to 5 MNT Bump actions/setup-python from 4 to 5 and fix tests Dec 11, 2023
@adrinjalali
Copy link
Copy Markdown
Member Author

@BenjaminBossan CI is finally happy and green!

@BenjaminBossan BenjaminBossan merged commit 01f4300 into skops-dev:main Dec 13, 2023
Copy link
Copy Markdown
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@adrinjalali adrinjalali deleted the dependabot/github_actions/actions/setup-python-5 branch December 14, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants