MNT bump codecov uploader#410
Merged
adrinjalali merged 1 commit intoskops-dev:mainfrom Feb 14, 2024
Merged
Conversation
Member
Author
|
Finally green. Seems like we needed a new codecov token. Not sure what all those matplotlib issues are though, and they don't make the CI fail, and I can reproduce locally. |
Member
Author
BenjaminBossan
approved these changes
Feb 13, 2024
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for figuring this out.
Not sure what all those matplotlib issues are though
What issues?
Member
Author
|
It's there in the 3.9 build in the test log. But we can ignore it it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #408