Testing CI#412
Merged
adrinjalali merged 2 commits intoskops-dev:mainfrom Feb 29, 2024
Merged
Conversation
Collaborator
Author
|
For latest sklearn, tests fail with:
|
Member
|
@BenjaminBossan you working on a fix? |
Collaborator
Author
|
So changing the import a bit seems to fix the issue. CI is still red thanks to codecov. The PR that broke the import is scikit-learn/scikit-learn#28486. In an associated thread, someone wrote some wise words: scikit-learn/scikit-learn#26686 (review) |
adrinjalali
approved these changes
Feb 29, 2024
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
We've hard coded the token for codecov in plain text, why is it empty lolol. Thanks for the fix @BenjaminBossan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge