Skip to content

[don't merge] Test hfh v0.27.0.rc0#459

Closed
hanouticelina wants to merge 1 commit intoskops-dev:mainfrom
hanouticelina:ci-test-huggingface-hub-v0.27.0.rc0
Closed

[don't merge] Test hfh v0.27.0.rc0#459
hanouticelina wants to merge 1 commit intoskops-dev:mainfrom
hanouticelina:ci-test-huggingface-hub-v0.27.0.rc0

Conversation

@hanouticelina
Copy link
Copy Markdown

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@BenjaminBossan
Copy link
Copy Markdown
Collaborator

@hanouticelina There has been a big refactor of the CI recently in #451. That's why this PR can't be run.

@adrinjalali do you think it's still necessary to check skops against HFH?

@adrinjalali
Copy link
Copy Markdown
Member

@adrinjalali do you think it's still necessary to check skops against HFH?

I don't think so. They're not maintained and we've removed some functionalities and deprecated some (to be removed in the coming release).

I was actually debating whether to keep them or not, since we haven't really had any usage of the hub front, and removing the dependency (or making it optional) would make the package significantly lighter. WDYT?

@BenjaminBossan
Copy link
Copy Markdown
Collaborator

Then I lean towards removing the dependency. For most dependencies, I might have told users: We have tested until version x.y.z, there is no support for newer versions. But given the nature of the HFH package, it's probably a better idea to remove the support completely.

@hanouticelina
Copy link
Copy Markdown
Author

thanks @BenjaminBossan, noted! I will close this PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants