MNT remove deprecated hub_utils#462
Merged
adrinjalali merged 4 commits intoskops-dev:mainfrom Jan 29, 2025
Merged
Conversation
Member
Author
|
And I'm not sure about the model card utils as well, since I haven't seen it used. |
BenjaminBossan
approved these changes
Jan 22, 2025
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
I'm fine with removing the functionality, as there does not appear to be any usage. In general, it feels like skops is used for the serialization part and the rest is pretty much ignored.
Member
Author
|
Merging this, will tackle the CI issue in the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated
hub_utilsfunctions, and made me realise the other tools are not really used then (we haven't had an issue about them ever).So I think it'd make sense to remove
hub_utils, and references to it. It would mean to change the docs and model card related work as well. Before moving forward, I thought I'd ask if we're okay with me moving forward with it.As far as I can tell, there hasn't been any activity about this on the HF hub since 2023, so on the HF side people probably wouldn't mind if these are removed.
cc @BenjaminBossan