MNT replace tabular with prettytable#466
Merged
adrinjalali merged 2 commits intoskops-dev:mainfrom Jan 30, 2025
Merged
Conversation
Comment on lines
+204
to
+206
| pass # type: ignore | ||
| else: | ||
| headers = self.table.keys() | ||
| self.table.keys() |
Collaborator
There was a problem hiding this comment.
Do these lines do anything? They can just be removed now, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tabulate started being flaky with the latest python/scikit-learn, and I checked and it's not very active anymore. Here we switch to
prettytablewhich is very active and maintained. It slightly changes the table formats, but it should be fine.