ENH harden Card by adding a flag to allow/disallow insecure pickle loading#485
Merged
adrinjalali merged 6 commits intoskops-dev:mainfrom Aug 6, 2025
Merged
ENH harden Card by adding a flag to allow/disallow insecure pickle loading#485adrinjalali merged 6 commits intoskops-dev:mainfrom
adrinjalali merged 6 commits intoskops-dev:mainfrom
Conversation
adrinjalali
reviewed
Aug 5, 2025
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
This looks pretty nice. Could also please add a changelog entry?
Also tests to check the raised error message and to make sure having a pickle file with a skops extension fails by default.
Contributor
Author
|
Hi @adrinjalali, added the changelog and tests |
adrinjalali
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces additional hardening for models loaded through
Card.If the model is in an insecure pickle format, it is now required to explicitly set a flag during
Cardobject creation to allow the operation.@adrinjalali