Play nicely when bootstrap dropdown is already loaded. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be awesome if it could be merged! |
Owner
|
@rosselliott / @JrmKrb - sorry for the delay on this. I missed it. Thank you for this PR! |
|
Can we get a version bump for this on npm? |
|
Thank you @skratchdot ! |
Owner
|
@rvaidya - the build isn't working for me right now. I'm going to try to make a few updates before publishing. Might finally get around to adding some tests as well. I probably won't get to this until after work today (so if I forget, feel free to drop another message in here) |
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 19, 2017
Fixes an issue introduced in skratchdot#61
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 19, 2017
Contributor
|
|
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 20, 2017
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 20, 2017
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 24, 2017
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If bootstrap.dropdown is already loaded then the multi select dropdown will never open as two handlers will be attached to the element. As the handlers will both toggle the 'open' class the net effect is that the dropdown will remain closed.