Skip to content

Set stdout so CLI completion feature works correctly #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lynnemorrison wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set stdout so CLI completion feature works correctly #2262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/cmd/skupper/root/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package root

import (
"os"
"slices"

"github.com/skupperproject/skupper/internal/cmd/skupper/common"
"github.com/skupperproject/skupper/internal/cmd/skupper/connector"
"github.com/skupperproject/skupper/internal/cmd/skupper/debug"
Expand Down Expand Up @@ -38,6 +41,11 @@ func NewSkupperRootCommand() *cobra.Command {

rootCmd.SetHelpCommand(&cobra.Command{Hidden: true})

completionCommands := []string{"completion", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd}
if slices.Contains(completionCommands, os.Args[1]) && len(os.Args) <= 2 {
Copy link
Member

@hash-d hash-d Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will panic if no arguments are given (there's no os.Args[1], then)

rootCmd.SetOut(os.Stderr)
}
Copy link
Contributor

@c-kruse c-kruse Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education, could you explain what is going on here? I'm not sure I follow the logic of setting the command output stream to stderr except for completion commands.

Copy link
Collaborator Author

@lynnemorrison lynnemorrison Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to fix the issue that Danilo found with completion command.
skupper completion subcommand throws errors into stdout #2135


return rootCmd
}

Expand Down