Skip to content

Conversation

@amusingaxl
Copy link
Contributor

No description provided.

@amusingaxl amusingaxl self-assigned this Oct 10, 2025
Copy link
Member

@riccardopersiani riccardopersiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses and evm/solidity version have been double checked.

There are some vulnerabilities while installing, maybe it's work an npm audit fix run.

⚠️ New tests seems like are not run from the CI, also I have this failing test locally. Seems like the CI is picking tests only from src.

testRevert_farm_init_whenMismatchingParams
[FAIL: next call did not revert as expected]

@amusingaxl amusingaxl changed the base branch from master to feat/sky-farms-deployment October 14, 2025 13:06
Copy link
Member

@riccardopersiani riccardopersiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo, should have capital W:

testFarm_integration_stakeGetRewardAndwithdraw

which should be

testFarm_integration_stakeGetRewardAndWithdraw

@riccardopersiani
Copy link
Member

riccardopersiani commented Oct 14, 2025

also some reawards typo appearing in the comments in tests.

@riccardopersiani
Copy link
Member

riccardopersiani commented Oct 14, 2025

rewards.onwer() typo

@riccardopersiani
Copy link
Member

riccardopersiani commented Oct 14, 2025

some vestid which should be vestId

@riccardopersiani
Copy link
Member

increaments

@amusingaxl
Copy link
Contributor Author

Fixing the typos in #37.
Thanks for spotting.

oddaf
oddaf previously approved these changes Oct 15, 2025
@riccardopersiani riccardopersiani self-requested a review October 15, 2025 07:49
Base automatically changed from feat/sky-farms-deployment to master October 23, 2025 14:19
@amusingaxl amusingaxl dismissed stale reviews from riccardopersiani and oddaf October 23, 2025 14:19

The base branch was changed.

Signed-off-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
@amusingaxl amusingaxl requested review from 0xLaz3r and removed request for riccardopersiani November 10, 2025 11:54
@amusingaxl amusingaxl merged commit 1f28462 into master Nov 15, 2025
2 checks passed
@amusingaxl amusingaxl deleted the feat/obex-subproxy-deployment-script branch November 15, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants