windows cmdutil #83
Merged
windows cmdutil #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdknives
approved these changes
May 29, 2021
Member
jdknives
left a comment
jdknives
left a comment
There was a problem hiding this comment.
Cant test it but it looks good to me from first glance. Someone needs to verify it builds and works on Windows.
alexadhy
added a commit
to alexadhy/skywire
that referenced
this pull request
May 29, 2021
Contributor
Author
|
can you merge this? |
jdknives
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Changes:
syslogand syscall signals definition incmdutil.How to test this PR:
go mod edit -replace github.com/skycoin/dmsg=../dmsgskywirebinaries viamake