Skip to content

Conversation

@alexadhy
Copy link
Contributor

@alexadhy alexadhy commented May 31, 2021

Part of #84

Changes:

  • Brings back the in-memory dmsgpty whitelist function

How to test this PR:

  • checkout this PR
  • in your local skywire repo directory, do go mod edit -replace github.com/skycoin/dmsg=../dmsg
  • test it in the integration test environment

@alexadhy alexadhy force-pushed the in-memory-whitelist-dmsgpty branch from 17a5fe9 to 1fb46ea Compare May 31, 2021 07:24
@jdknives
Copy link
Member

jdknives commented Jun 2, 2021

Its a start. Skywire still does not build because of

GO111MODULE=on go install "-ldflags=-X github.com/skycoin/dmsg/buildinfo.version=v0.1.1-327-gae14da58 -X github.com/skycoin/dmsg/buildinfo.date=2021-06-02T18:10:38Z -X github.com/skycoin/dmsg/buildinfo.commit=ae14da58cac0051d95693f0454b4e341d97fe962" -mod=vendor  ./cmd/skywire-visor ./cmd/skywire-cli ./cmd/setup-node
# github.com/skycoin/skywire/pkg/visor
pkg/visor/init_unix.go:42:16: undefined: dmsgpty.NewJSONFileWhiteList
make: *** [Makefile:71: install] Fehler 2

@alexadhy
Copy link
Contributor Author

alexadhy commented Jun 3, 2021

@jdknives We have two options, do I need to rename this

func NewConfigWhitelist(confPath string) (Whitelist, error) {
function to NewJSONFileWhiteList or to rename the one in the skywire repo proper

@jdknives
Copy link
Member

jdknives commented Jun 3, 2021

You can rename it in skywire repo @alexadhy

@jdknives jdknives marked this pull request as ready for review June 3, 2021 13:05
Copy link
Contributor

@ersonp ersonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Build is working in integration test environment and also the full terminal in hypervisor.

@jdknives jdknives merged commit 3cba29f into skycoin:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants