Navrespon#72
Open
cecil211-mch wants to merge 7 commits into
Open
Conversation
… in buttons also tried to workwith the responsiveness
mulfranck
requested changes
Sep 5, 2022
Collaborator
mulfranck
left a comment
mulfranck
left a comment
There was a problem hiding this comment.
Why are so many js files in your work?
Plz, make sure to allow pull changes online before pushing - your branch has conflict with the main branch.
I see jquery in your commits, we are not using bootstrap 4 - so jquery is not needed.
Given the number of js files - I can't accept your PR
Collaborator
Author
|
Bootstrap5 links were not working for me, that's why I went on with
bootstrap4
…On Mon, Sep 5, 2022, 18:20 Nji Franclin Muluh ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Why are so many js files in your work?
Plz, make sure to allow pull changes online before pushing - your branch
has conflict with the main branch.
I see jquery in your commits, we are not using bootstrap 4 - so jquery is
not needed.
Given the number of js files - I can't accept your PR
—
Reply to this email directly, view it on GitHub
<#72 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWR7ZKZOQVOXWHJT6D4OABDV4YTWRANCNFSM6AAAAAAQFE5U5U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the styles of the navbar, I tried for it to be responsive, I also changed the styles of the welcome message and the login button to be centralised
Solving #71