Fix missing get_solar_data import error#16
Merged
Conversation
The generate_predictions.py script was importing get_solar_data from the solar module, but this function doesn't exist. The import was unused anyway - the script uses its own fetch_solar_conditions() function to get solar data from NOAA. Fixes: Generator failed error when importing DVOACAP modules
Changed engine.muf_calculator.muf to engine.circuit_muf.muf. MufCalculator is the class that performs calculations, while CircuitMuf is the result dataclass that contains the actual MUF value. The previous code was checking for muf_calculator (which exists) but trying to access a .muf attribute that doesn't exist on that class, causing MUF values to always be 0 in predictions. Fixes: MUF values always showing as 0 in prediction output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.