Merged
Conversation
The validation script was incorrectly marking API errors as "MATCH" when both predictions failed (0% reliability, -999 SNR). This happened because: - Reliability: 0% vs 0% = 0% diff, within tolerance - SNR: Both invalid (-999), so comparison was skipped - Result: No mismatches = "MATCH" ✓ (wrong!) Changes: - Add early error detection in compare_predictions() - Check for invalid SNR (≤-900), ERROR mode, or ERROR quality - Mark as error and fail immediately if either prediction failed - Update output to show "⚠ ERROR" instead of "✓ MATCH" - Prevent false positives where two failures counted as a match Now properly reports: "⚠ ERROR → VOACAP online prediction failed"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation script was incorrectly marking API errors as "MATCH" when both predictions failed (0% reliability, -999 SNR). This happened because:
Changes:
Now properly reports: "⚠ ERROR → VOACAP online prediction failed"