Conversation
Fixed multiple critical bugs that were preventing propagation modes from being found: 1. **reflectrix.find_modes() bug**: The method returns None but stores results in self.modes. Code was checking the return value instead of reflectrix.modes, causing all modes to be skipped. 2. **Attribute name mismatches**: Fixed inconsistent attribute names throughout codebase: - mode.hop_count → mode.hop_cnt (ModeInfo uses hop_cnt) - mode.reflection → mode.ref (ModeInfo uses ref for Reflection data) - mode.hop_distance → mode.hop_dist (ModeInfo uses hop_dist) - mode.layer.name → mode.layer (layer is string, not enum) - muf_info.reflection → muf_info.ref (MufInfo uses ref) 3. **Missing signal attribute**: Added signal attribute to ModeInfo class and initialized it in _compute_signal() before use. 4. **get_mode_name() type handling**: Fixed to handle both enum and string layer types. **Status**: Modes are now being found (was 0, now finding 1-3 modes per frequency). However, signal calculations are producing nan values due to sqrt of negative numbers in ground reflection calculations - this will be addressed in next commit. **Progress**: - Before: 30.6% validation pass rate (but many had SNR=0) - After: 3.7% pass rate (modes found but calculations need fixing) Relates to FORTRAN_ANALYSIS_AND_RECOMMENDATIONS.md Priority 1 tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed multiple critical bugs that were preventing propagation modes from being found:
reflectrix.find_modes() bug: The method returns None but stores results in self.modes. Code was checking the return value instead of reflectrix.modes, causing all modes to be skipped.
Attribute name mismatches: Fixed inconsistent attribute names throughout codebase:
Missing signal attribute: Added signal attribute to ModeInfo class and initialized it in _compute_signal() before use.
get_mode_name() type handling: Fixed to handle both enum and string layer types.
Status: Modes are now being found (was 0, now finding 1-3 modes per frequency). However, signal calculations are producing nan values due to sqrt of negative numbers in ground reflection calculations - this will be addressed in next commit.
Progress:
Relates to FORTRAN_ANALYSIS_AND_RECOMMENDATIONS.md Priority 1 tasks.