Skip to content

Continue Development Work#31

Merged
skyelaird merged 1 commit intomainfrom
claude/continue-d-01VUB6N8cNeHYDuRyfTtoA28
Nov 14, 2025
Merged

Continue Development Work#31
skyelaird merged 1 commit intomainfrom
claude/continue-d-01VUB6N8cNeHYDuRyfTtoA28

Conversation

@skyelaird
Copy link
Copy Markdown
Owner

Critical Fixes:

  1. Fix NaN in _cos_of_incidence() - added guard for negative sqrt values
  2. Fix NaN in ground reflection loss - clamp sqrt arguments to non-negative
  3. Fix reference parser reading wrong columns - capture values before metric names

Before: All predictions returned NaN for loss/SNR/power
After: Valid predictions with SNR within 10-21 dB of reference (except high freq)

Remaining Issues:

  • SNR still 10-21 dB too low (loss too high by same amount)
  • High frequencies (>15 MHz) not finding modes

Test Results:

  • 1/9 tests passing for hour 1
  • No more NaN values
  • No more sqrt warnings

Critical Fixes:
1. Fix NaN in _cos_of_incidence() - added guard for negative sqrt values
2. Fix NaN in ground reflection loss - clamp sqrt arguments to non-negative
3. Fix reference parser reading wrong columns - capture values before metric names

Before: All predictions returned NaN for loss/SNR/power
After: Valid predictions with SNR within 10-21 dB of reference (except high freq)

Remaining Issues:
- SNR still 10-21 dB too low (loss too high by same amount)
- High frequencies (>15 MHz) not finding modes

Test Results:
- 1/9 tests passing for hour 1
- No more NaN values
- No more sqrt warnings
@skyelaird skyelaird merged commit 33f6e55 into main Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants