Merged
Conversation
Critical Fixes: 1. Fix NaN in _cos_of_incidence() - added guard for negative sqrt values 2. Fix NaN in ground reflection loss - clamp sqrt arguments to non-negative 3. Fix reference parser reading wrong columns - capture values before metric names Before: All predictions returned NaN for loss/SNR/power After: Valid predictions with SNR within 10-21 dB of reference (except high freq) Remaining Issues: - SNR still 10-21 dB too low (loss too high by same amount) - High frequencies (>15 MHz) not finding modes Test Results: - 1/9 tests passing for hour 1 - No more NaN values - No more sqrt warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical Fixes:
Before: All predictions returned NaN for loss/SNR/power
After: Valid predictions with SNR within 10-21 dB of reference (except high freq)
Remaining Issues:
Test Results: