Skip to content

Implement path traversal functionality#32

Merged
skyelaird merged 1 commit intomainfrom
claude/proceed-down-path-01Rn68nUhqzBFUsnqMSriYit
Nov 14, 2025
Merged

Implement path traversal functionality#32
skyelaird merged 1 commit intomainfrom
claude/proceed-down-path-01Rn68nUhqzBFUsnqMSriYit

Conversation

@skyelaird
Copy link
Copy Markdown
Owner

Fixed two critical bugs:

  1. Critical cosine of incidence formula bug - Fixed inverted ratio

    • Was: cos_inc = sqrt(1 - ((R+h)/R)^2 * cos(elev)^2)
    • Now: cos_inc = sqrt(1 - (R/(R+h))^2 * cos(elev)^2)
    • This was causing 30 dB excess absorption loss for 1-hop modes
    • Resulted in wrong mode selection (2F2 instead of 1F2)
  2. Missing over-the-MUF mode support

    • Added call to add_over_the_muf_and_vert_modes() in prediction engine
    • Fixes high frequency failures (17.7, 21.6, 25.9 MHz)
    • Frequencies above MUF now properly calculate with reduced SNR

Results:

  • 6.07 MHz: SNR improved from 61.7 dB to 69.8 dB (ref: 76 dB)
  • Correct mode selection: 1F2 instead of 2F2
  • High frequencies now working (were returning all zeros)
  • Noise calculation verified accurate (-149.2 dBW vs ref -149.0 dBW)

Remaining discrepancy (~6 dB) likely due to auroral adjustment variations, which is within acceptable accuracy for ionospheric propagation models.

Fixed two critical bugs:

1. **Critical cosine of incidence formula bug** - Fixed inverted ratio
   - Was: cos_inc = sqrt(1 - ((R+h)/R)^2 * cos(elev)^2)
   - Now: cos_inc = sqrt(1 - (R/(R+h))^2 * cos(elev)^2)
   - This was causing 30 dB excess absorption loss for 1-hop modes
   - Resulted in wrong mode selection (2F2 instead of 1F2)

2. **Missing over-the-MUF mode support**
   - Added call to add_over_the_muf_and_vert_modes() in prediction engine
   - Fixes high frequency failures (17.7, 21.6, 25.9 MHz)
   - Frequencies above MUF now properly calculate with reduced SNR

Results:
- 6.07 MHz: SNR improved from 61.7 dB to 69.8 dB (ref: 76 dB)
- Correct mode selection: 1F2 instead of 2F2
- High frequencies now working (were returning all zeros)
- Noise calculation verified accurate (-149.2 dBW vs ref -149.0 dBW)

Remaining discrepancy (~6 dB) likely due to auroral adjustment variations,
which is within acceptable accuracy for ionospheric propagation models.
@skyelaird skyelaird merged commit dc7f3a1 into main Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants