Merged
Conversation
Fixed two critical bugs: 1. **Critical cosine of incidence formula bug** - Fixed inverted ratio - Was: cos_inc = sqrt(1 - ((R+h)/R)^2 * cos(elev)^2) - Now: cos_inc = sqrt(1 - (R/(R+h))^2 * cos(elev)^2) - This was causing 30 dB excess absorption loss for 1-hop modes - Resulted in wrong mode selection (2F2 instead of 1F2) 2. **Missing over-the-MUF mode support** - Added call to add_over_the_muf_and_vert_modes() in prediction engine - Fixes high frequency failures (17.7, 21.6, 25.9 MHz) - Frequencies above MUF now properly calculate with reduced SNR Results: - 6.07 MHz: SNR improved from 61.7 dB to 69.8 dB (ref: 76 dB) - Correct mode selection: 1F2 instead of 2F2 - High frequencies now working (were returning all zeros) - Noise calculation verified accurate (-149.2 dBW vs ref -149.0 dBW) Remaining discrepancy (~6 dB) likely due to auroral adjustment variations, which is within acceptable accuracy for ionospheric propagation models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two critical bugs:
Critical cosine of incidence formula bug - Fixed inverted ratio
Missing over-the-MUF mode support
Results:
Remaining discrepancy (~6 dB) likely due to auroral adjustment variations, which is within acceptable accuracy for ionospheric propagation models.