Skip to content

Reconnect and resume phase 5 work#5

Merged
skyelaird merged 1 commit intomainfrom
claude/phase-5-acr-reconnect-011CV6JDLRoYxDLPQAwbgqNa
Nov 13, 2025
Merged

Reconnect and resume phase 5 work#5
skyelaird merged 1 commit intomainfrom
claude/phase-5-acr-reconnect-011CV6JDLRoYxDLPQAwbgqNa

Conversation

@skyelaird
Copy link
Copy Markdown
Owner

This commit continues Phase 5 development by fixing numerous attribute name mismatches between modules and improving integration of the prediction engine.

Changes:

  • Fixed attribute names in PathGeometry (azim_tr/azim_rt vs azim_tx_to_rx/azim_rx_to_tx)
  • Fixed FourierMaps method name (set_conditions vs set_month_ssn_utc)
  • Fixed solar.py to use correct GeoPoint attributes (lat/lon vs latitude/longitude)
  • Updated prediction_engine.py to handle GeographicPoint vs GeoPoint conversion
  • Added defaults to ControlPoint dataclass to enable instantiation
  • Fixed geomagnetic field parameter mapping in prediction engine
  • Fixed ControlPoint layer attribute names (e/f1/f2 vs e_layer/f1_layer/f2_layer)
  • Updated README to reflect Phase 5 progress (85% complete)
  • Created complete_prediction_example.py for end-to-end testing

Working:

  • phase5_signal_example.py runs successfully
  • Noise modeling (atmospheric, galactic, man-made)
  • Antenna gain calculations
  • Basic signal budget calculations

In Progress:

  • Full prediction engine end-to-end integration
  • CircuitMuf API compatibility
  • Additional attribute name standardization across modules

The core Phase 5 components are functional. The full integration requires additional work to resolve remaining API mismatches between modules.

This commit continues Phase 5 development by fixing numerous attribute name
mismatches between modules and improving integration of the prediction engine.

Changes:
- Fixed attribute names in PathGeometry (azim_tr/azim_rt vs azim_tx_to_rx/azim_rx_to_tx)
- Fixed FourierMaps method name (set_conditions vs set_month_ssn_utc)
- Fixed solar.py to use correct GeoPoint attributes (lat/lon vs latitude/longitude)
- Updated prediction_engine.py to handle GeographicPoint vs GeoPoint conversion
- Added defaults to ControlPoint dataclass to enable instantiation
- Fixed geomagnetic field parameter mapping in prediction engine
- Fixed ControlPoint layer attribute names (e/f1/f2 vs e_layer/f1_layer/f2_layer)
- Updated README to reflect Phase 5 progress (85% complete)
- Created complete_prediction_example.py for end-to-end testing

Working:
- phase5_signal_example.py runs successfully
- Noise modeling (atmospheric, galactic, man-made)
- Antenna gain calculations
- Basic signal budget calculations

In Progress:
- Full prediction engine end-to-end integration
- CircuitMuf API compatibility
- Additional attribute name standardization across modules

The core Phase 5 components are functional. The full integration requires
additional work to resolve remaining API mismatches between modules.
@skyelaird skyelaird merged commit d45667b into main Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants