Merged
Conversation
This commit continues Phase 5 development by fixing numerous attribute name mismatches between modules and improving integration of the prediction engine. Changes: - Fixed attribute names in PathGeometry (azim_tr/azim_rt vs azim_tx_to_rx/azim_rx_to_tx) - Fixed FourierMaps method name (set_conditions vs set_month_ssn_utc) - Fixed solar.py to use correct GeoPoint attributes (lat/lon vs latitude/longitude) - Updated prediction_engine.py to handle GeographicPoint vs GeoPoint conversion - Added defaults to ControlPoint dataclass to enable instantiation - Fixed geomagnetic field parameter mapping in prediction engine - Fixed ControlPoint layer attribute names (e/f1/f2 vs e_layer/f1_layer/f2_layer) - Updated README to reflect Phase 5 progress (85% complete) - Created complete_prediction_example.py for end-to-end testing Working: - phase5_signal_example.py runs successfully - Noise modeling (atmospheric, galactic, man-made) - Antenna gain calculations - Basic signal budget calculations In Progress: - Full prediction engine end-to-end integration - CircuitMuf API compatibility - Additional attribute name standardization across modules The core Phase 5 components are functional. The full integration requires additional work to resolve remaining API mismatches between modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit continues Phase 5 development by fixing numerous attribute name mismatches between modules and improving integration of the prediction engine.
Changes:
Working:
In Progress:
The core Phase 5 components are functional. The full integration requires additional work to resolve remaining API mismatches between modules.